Fix ftReceiptTotal #285
Closed
Fix ftReceiptTotal #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKert
reviewed
May 15, 2024
| @@ -351,7 +351,7 @@ public async Task<ftReceiptJournal> CreateReceiptJournalAsync(ftQueue queue, ftQ | |||
| } | |||
| else | |||
| { | |||
| receiptjournal.ftReceiptTotal = (receiptrequest?.cbChargeItems?.Sum(ci => ci.Amount)).GetValueOrDefault(); | |||
| receiptjournal.ftReceiptTotal = (receiptrequest?.cbChargeItems?.Sum(ci => Math.Sign(ci.Quantity) * ci.Amount)).GetValueOrDefault(); | |||
There was a problem hiding this comment.
ftReceiptTotal should always be the straight sum of the Amounts. This is due to the definition of how we have specified usage of Amount / chargeitems in the interface docs. Taking the Quantity into the calculation will make the calculation wrong for a lot of cases so we must not change that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{Summary of the changes}
Description
{Detail}
Fixes #{issue number}